Вызов Form::markCustom addCustomLabel одним методом #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment "label" to set it without calling special method
AlexeyDsov
added a commit
that referenced
this pull request
Sep 26, 2012
Calling methods Form::mark(Custom|Wrong|Missing) add(Custom|Wrong|Missing)Label through one method
|
Замержено в мастер. В 1.0 мержить не стал, но могу сделать, по желанию. |
|
Плюсую в 1.0, ибо bc не ломается. |
|
Добавил в 1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
В очередной раз писал кастомные ошибки и надоело писать что-то вроде:
Хочется добавить 3-ий не обязательный аргумент $label в метод markCustom и если он присутствует, то уж markCustom внутри и вызовет addCustomLabel, т.е. что бы снаружи выглядело вот так:
З.Ы. на github наконец пофиксили для php кода, что не надо писать открывающий php тэг, что бы код подсвечивался